-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder and add https://lnnodeinsight.com/ to the discover page with a new category: Node management #2233
Conversation
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
Please assign someone to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @SiddheshKukade, looks good! 🙌
Will merge as soon as @MoritzKa replaced the images.
{ | ||
"title": "LNnodeinsight.com", | ||
"subtitle": "Develop your own data-driven Lightning Network insight", | ||
"logo": "https://lnnodeinsight.com/www/LNnodeinsight-tinylogonobkgrnd-white.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MoritzKa Can you please upload the logos files to our CDN and replace the paths here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…etAlby#2263)" This reverts commit ded7358.
My apologies for the extra commits. I accidentally pushed them into the wrong branch. |
The UI looks good and links are working. I did not check the code though. |
@MoritzKa the changes are mostly some JSON refactoring and added code for Node management and added section for LND nodeinsight.com. Let me know if anything's unclear in code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Thanks for your work on this PR @SiddheshKukade 🙌 |
@reneaaron it's my pleasure |
Describe the changes you have made in this PR
Reordered the sections on the Discover page and added new section of node management with lnnodeinsight.com as a card.
Link this PR to an issue [optional]
Fixes #2111
Type of change
refactor
: refactored the sections of the discover page.feat
: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Checklist