Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder and add https://lnnodeinsight.com/ to the discover page with a new category: Node management #2233

Merged
merged 12 commits into from
Apr 3, 2023

Conversation

SiddheshKukade
Copy link
Contributor

@SiddheshKukade SiddheshKukade commented Mar 18, 2023

Describe the changes you have made in this PR

Reordered the sections on the Discover page and added new section of node management with lnnodeinsight.com as a card.

Link this PR to an issue [optional]

Fixes #2111

Type of change

  • refactor: refactored the sections of the discover page.
  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

image
image

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@SiddheshKukade SiddheshKukade marked this pull request as ready for review March 18, 2023 11:01
@github-actions
Copy link

github-actions bot commented Mar 19, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@SiddheshKukade
Copy link
Contributor Author

Please assign someone to review.

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @SiddheshKukade, looks good! 🙌

Will merge as soon as @MoritzKa replaced the images.

{
"title": "LNnodeinsight.com",
"subtitle": "Develop your own data-driven Lightning Network insight",
"logo": "https://lnnodeinsight.com/www/LNnodeinsight-tinylogonobkgrnd-white.svg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoritzKa Can you please upload the logos files to our CDN and replace the paths here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Here's how it looks :
image

@escapedcat escapedcat requested a review from MoritzKa March 22, 2023 11:36
@SiddheshKukade
Copy link
Contributor Author

SiddheshKukade commented Mar 26, 2023

My apologies for the extra commits. I accidentally pushed them into the wrong branch.
Now, I've fixed them. 👍🏻
@MoritzKa the code is ready to be reviewed.

@MoritzKa
Copy link
Contributor

The UI looks good and links are working. I did not check the code though.

@SiddheshKukade
Copy link
Contributor Author

The UI looks good and links are working. I did not check the code though.

@MoritzKa the changes are mostly some JSON refactoring and added code for Node management and added section for LND nodeinsight.com. Let me know if anything's unclear in code.

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit 9c2279b into getAlby:master Apr 3, 2023
@reneaaron
Copy link
Contributor

Thanks for your work on this PR @SiddheshKukade 🙌

@SiddheshKukade
Copy link
Contributor Author

@reneaaron it's my pleasure ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder and add https://lnnodeinsight.com/ to the discover page with a new category: Node management
4 participants